Dfuds implementation#46
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| /** | ||
| * @brief Returns the size of the tree | ||
| */ | ||
| size_t size() const { return num_bits_ / 2; } |
There was a problem hiding this comment.
WARNING: size() returns an incorrect node count
num_bits_ is initialized as 2 * tree_size - 1, so num_bits_ / 2 evaluates to tree_size - 1 for all non-empty trees. This under-reports the actual tree size by one and can break callers relying on size() for bounds or traversal logic.
| "${BUILD_DIR}/unittests" | ||
| "${BUILD_DIR}/excess_positions_tests" | ||
| "${BUILD_DIR}/louds_tree_tests" | ||
| "${BUILD_DIR}/dfus_tree_tests" |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.3-codex · 123,918 tokens |
Sanya239
force-pushed
the
dfuds-implementation
branch
3 times, most recently
from
a6575a7 to
c447002
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 89.58% 89.22% -0.37%
==========================================
Files 15 17 +2
Lines 4416 4556 +140
Branches 814 828 +14
==========================================
+ Hits 3956 4065 +109
- Misses 280 284 +4
- Partials 180 207 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sanya239
force-pushed
the
dfuds-implementation
branch
from
965798b to
8da3cca
Compare
Sanya239
force-pushed
the
dfuds-implementation
branch
from
8da3cca to
e32c846
Compare
2 participants
No description provided.